UseBB Community

Find in functions.php:

Quote

$out[] = '<a href="javascript:insert_tags(\''.$data[0].'\', \''.$data[1].'\')" style="'.$data[3].'">'.$data[2].'</a>';

Replace it with:

Quote

$out[] = '<a href="javascript:insert_tags(\''.$data[0].'\',%20\''.$data[1].'\')" style="'.$data[3].'">'.$data[2].'</a>';

The reason for the HTML code of the editor buttons not to validate, is caused by a space between the arrays data[0] and data[1].
Result of this patch: ~10 HTML warnings less.

I don't seem to get any warnings when validating the post form...?

I use a Firefox extension to validate it. It's called Tidy.

I see. We could fix this problem easily, though I should mention that those BBCode controls weren't really made the way Javascript controls should be. These are put into the href attribute, while it should be at least into the onclick attribute.

In a perfect world, it should all be rendered using the DOM, which is what we are going to try with UseBB 2. So for now I'll try to change it, eventually using onclick, but it remains a dirty implementation somehow.

Edit: fixed in CVS.

Thanks for taking the time I hope I can take some time in the new year to improve version 1, possibly helping you out when v2 is released, but don't count me on it